New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pagination when offset is set #10778

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
6 participants
@sarjon
Member

sarjon commented Sep 30, 2018

Questions Answers
Branch? 1.7.5.x
Description? When deleting a last item from a page, you still remain in the same page even though it's empty after deletion. The pagination disappears aswell, so there's no way to get back to the previous page.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? See below.

To reproduce before PR: have 11 items in the grid, showing 10 per page. Delete the 11th item while being in the second page. After deletion you will stay in 2nd page without pagination. Can be reproduced in sql manager list.

After applying this PR: follow same steps as above. After deletion you will stay in same page and see pagination even though list for 2nd page is empty.


This change is Reviewable

@matks matks added this to the 1.7.5.0 milestone Oct 1, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 2, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 816c3be into PrestaShop:1.7.5.x Oct 3, 2018

1 of 2 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 3, 2018

Thank you @sarjon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment