Migration of Advanced Parameters > Team > Profiles page. #10783

rokaszygmantas · Sep 30, 2018

Questions	Answers
Branch?	develop
Description?	This PR migrates the profiles list page (Advanced Parameters > Team > Profiles).
Type?	improvement
Category?	CO
BC breaks?	no
Deprecations?	no
Fixed ticket?	#10505
How to test?	Compare to the legacy controller. This PR migrates only the listing page of Profiles. URL: `admin-dev/index.php/configure/advanced/profiles/`. You have to rebuild the assets before testing. Superadmin specific rules will be done in another PR (see #10505)

Create grid
Implement grid actions
Specific logic on grid bulk/row actions

This change is

mickaelandrieu · Oct 4, 2018

mickaelandrieu reviewed Oct 4, 2018

View changes

mickaelandrieu · Oct 4, 2018

src/PrestaShopBundle/Controller/Admin/Configure/AdvancedParameters/ProfilesController.php

+        $definitionFactory = $definitionFactory->getDefinition();
+
+        $gridFilterFormFactory = $this->get('prestashop.core.grid.filter.form_factory');
+        $searchParametersForm = $gridFilterFormFactory->create($definitionFactory);


should be createForm($definitionFactory), I've forgotten to update it :/

👍 for createForm and not getForm. :p

Why redundant Form, a form factory can only create form... create is the right name

@PierreRambaud where were you when we had discussion with @mickaelandrieu about that for other services. -_- i needed your backup. :p

Didn't see the discussion... Too many things to do :'(

Always call me when you want someone to do mess with naming 😄

we may still fix that untill 1.7.5 release if you get @mickaelandrieu on your side. 😄

@matks wdyt too?

I'm sorry, I'm going to disappoint all of you ^^ : I think both names are right. One is more redundant, but both names provide the required information ("what is this function doing ?") very accurately so I do not care.

I think it's too late to change the name, but if we can I stand for getForm() for consistency with all others functions in the Grid component.

tomas862 · Oct 20, 2018

tomas862 reviewed Oct 20, 2018

View changes

tomas862 · Oct 20, 2018

src/Core/Grid/Definition/Factory/ProfilesGridDefinitionFactory.php

+     */
+    protected function getId()
+    {
+        return 'profiles';


All new grid ids starts with upper-case

Suggested change Beta

Give us feedback

return 'profiles';

return 'Profiles';

is it a convention? If yes, it needs to be documented.

tomas862 · Oct 20, 2018

tomas862 reviewed Oct 20, 2018

View changes

src/Core/Grid/Query/ProfilesQueryBuilder.php

tomas862 · Oct 20, 2018

tomas862 reviewed Oct 20, 2018

View changes

tomas862 · Oct 20, 2018

src/PrestaShopBundle/Controller/Admin/Configure/AdvancedParameters/ProfilesController.php

+     * Shows profile edit form.
+     *
+     * @AdminSecurity(
+     *     "is_granted('update', request.get('_legacy_controller'))",


Provide redirectRoute parameter

Suggested change Beta

Give us feedback

* "is_granted('update', request.get('_legacy_controller'))",

* "is_granted('update', request.get('_legacy_controller'))",

* redirectRoute="admin_profiles",

tomas862 · Oct 20, 2018

tomas862 reviewed Oct 20, 2018

View changes

...dle/Controller/Admin/Configure/AdvancedParameters/ProfilesController.php

tomas862 · Oct 20, 2018

tomas862 reviewed Oct 20, 2018

View changes

...esources/config/routing/admin/configure/advanced_parameters/profiles.yml

tomas862 · Oct 20, 2018

tomas862 reviewed Oct 20, 2018

View changes

...dle/Controller/Admin/Configure/AdvancedParameters/ProfilesController.php

rokaszygmantas · Dec 21, 2018

Hi @matks,

This listing page migrated, except there is one thing that is different compared to legacy controller, and it can be seen in these screenshots:
Legacy: https://prnt.sc/lxvy86
Migrated: https://prnt.sc/lxvy2v
The bulk actions are rendered for all rows and the accessibility checking is not implemented for bulk actions in the grid component yet. I've talked with @sarjon about this and we came to a conclusion that it would be better to open another PR with this improvement to grid component, because it's a global change needed for many grid implementations. Wdyt?

Btw the backend accessibility checking is implemented, so you cannot delete the super admin profile, it's just that the checkbox is displayed visually.

matks · Dec 21, 2018

@rokaszygmantas Great 👍

Yes it's nice to split deliverables into several PRs. I added this item to the issue todlist so we dont forget.

Now I've got to review 😄

matks · Jan 11, 2019

matks reviewed Jan 11, 2019

View changes

Almost nothing more to add than Tomas and Mickael 😄

src/Core/Grid/Query/ProfilesQueryBuilder.php

...dle/Controller/Admin/Configure/AdvancedParameters/ProfilesController.php

matks · Jan 11, 2019

@rokaszygmantas (finally) reviewed ! sorry for the wait ...

rokaszygmantas · Jan 30, 2019

Hi @matks,

I've removed the SearchById form type now and introduced new size option for TextType types.

I didn't implement other size options besides small, they can be easily added when needed. 🙂

matks · Jan 30, 2019

matks approved these changes Jan 30, 2019

View changes

matks · Jan 30, 2019

I think we dont need to bother QA to review the UX feedback 😄

matks · Jan 30, 2019

Thank you @rokaszygmantas !

prestonBot added develop Improvement waiting for wording labels Sep 30, 2018

LouiseBonnard removed the waiting for wording label Oct 1, 2018

rokaszygmantas force-pushed the rokaszygmantas:migration/employees_profiles branch from a8afa90 to ca12b09 Oct 11, 2018

prestonBot added the waiting for wording label Oct 26, 2018

matks added the migration label Dec 5, 2018

mickaelandrieu added this to the 1.7.6.0 milestone Dec 10, 2018

mickaelandrieu added waiting for rebase and removed waiting for wording labels Dec 10, 2018

mickaelandrieu assigned matks Dec 10, 2018

matks referenced this pull request Dec 12, 2018
Open
Migrate "Advanced Parameters > Team > Employees > Profiles" page #10505
1 of 2 tasks complete

rokaszygmantas force-pushed the rokaszygmantas:migration/employees_profiles branch from 57552d3 to e1ef03a Dec 13, 2018

prestonBot added the waiting for wording label Dec 20, 2018

rokaszygmantas force-pushed the rokaszygmantas:migration/employees_profiles branch from 8546440 to 0a2f886 Dec 21, 2018

matks changed the title ~~[WIP] Migration of Advanced Parameters > Team > Profiles page.~~ Migration of Advanced Parameters > Team > Profiles page. Jan 11, 2019

matks added waiting for author and removed waiting for rebase waiting for wording labels Jan 11, 2019

rokaszygmantas force-pushed the rokaszygmantas:migration/employees_profiles branch from c7ea4af to 939bf0d Jan 30, 2019

rokaszygmantas added some commits Jan 30, 2019

Remove SearchById form type

dc3da42

Introduce size option for text inputs

Loading status checks…

cba94c3

Fix cs

Loading status checks…

38e12f8

matks merged commit 78501e2 into PrestaShop:develop Jan 30, 2019
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

rokaszygmantas deleted the rokaszygmantas:migration/employees_profiles branch Jan 30, 2019

prestonBot added the waiting for wording label Jan 30, 2019

matks removed waiting for author waiting for wording labels Jan 30, 2019

PrestaShop/PrestaShop

Join GitHub today

Migration of Advanced Parameters > Team > Profiles page. #10783

Conversation

rokaszygmantas commented Sep 30, 2018 • edited by matks

prestonBot added develop Improvement waiting for wording labels Sep 30, 2018

LouiseBonnard removed the waiting for wording label Oct 1, 2018

mickaelandrieu reviewed Oct 4, 2018 View changes

This comment has been minimized.

mickaelandrieu Oct 4, 2018 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rokaszygmantas force-pushed the rokaszygmantas:migration/employees_profiles branch from a8afa90 to ca12b09 Oct 11, 2018

tomas862 reviewed Oct 20, 2018 View changes

This comment has been minimized.

tomas862 Oct 20, 2018 • edited

This comment has been minimized.

tomas862 reviewed Oct 20, 2018 View changes

tomas862 reviewed Oct 20, 2018 View changes

This comment has been minimized.

tomas862 reviewed Oct 20, 2018 View changes

tomas862 reviewed Oct 20, 2018 View changes

tomas862 reviewed Oct 20, 2018 View changes

prestonBot added the waiting for wording label Oct 26, 2018

matks added the migration label Dec 5, 2018

mickaelandrieu added this to the 1.7.6.0 milestone Dec 10, 2018

mickaelandrieu added waiting for rebase and removed waiting for wording labels Dec 10, 2018

mickaelandrieu assigned matks Dec 10, 2018

matks referenced this pull request Dec 12, 2018

rokaszygmantas force-pushed the rokaszygmantas:migration/employees_profiles branch from 57552d3 to e1ef03a Dec 13, 2018

prestonBot added the waiting for wording label Dec 20, 2018

rokaszygmantas force-pushed the rokaszygmantas:migration/employees_profiles branch from 8546440 to 0a2f886 Dec 21, 2018

This comment has been minimized.

rokaszygmantas commented Dec 21, 2018 • edited

This comment has been minimized.

matks commented Dec 21, 2018

matks changed the title [WIP] Migration of Advanced Parameters > Team > Profiles page. Migration of Advanced Parameters > Team > Profiles page. Jan 11, 2019

matks reviewed Jan 11, 2019 View changes

matks left a comment • edited

This comment has been minimized.

matks commented Jan 11, 2019

matks added waiting for author and removed waiting for rebase waiting for wording labels Jan 11, 2019

rokaszygmantas added some commits Sep 30, 2018

rokaszygmantas force-pushed the rokaszygmantas:migration/employees_profiles branch from c7ea4af to 939bf0d Jan 30, 2019

rokaszygmantas added some commits Jan 30, 2019

This comment has been minimized.

rokaszygmantas commented Jan 30, 2019

matks approved these changes Jan 30, 2019 View changes

This comment has been minimized.

matks commented Jan 30, 2019

This comment has been minimized.

matks commented Jan 30, 2019

Hide details View details matks merged commit 78501e2 into PrestaShop:develop Jan 30, 2019 1 check passed

1 check passed

rokaszygmantas deleted the rokaszygmantas:migration/employees_profiles branch Jan 30, 2019

prestonBot added the waiting for wording label Jan 30, 2019

matks removed waiting for author waiting for wording labels Jan 30, 2019

rokaszygmantas commented Sep 30, 2018 •

edited by matks

mickaelandrieu reviewed Oct 4, 2018

View changes

mickaelandrieu Oct 4, 2018 •

edited

rokaszygmantas force-pushed the rokaszygmantas:migration/employees_profiles branch from `a8afa90` to `ca12b09` Oct 11, 2018

tomas862 reviewed Oct 20, 2018

View changes

tomas862 Oct 20, 2018 •

edited

tomas862 reviewed Oct 20, 2018

View changes

tomas862 reviewed Oct 20, 2018

View changes

tomas862 reviewed Oct 20, 2018

View changes

tomas862 reviewed Oct 20, 2018

View changes

tomas862 reviewed Oct 20, 2018

View changes

rokaszygmantas force-pushed the rokaszygmantas:migration/employees_profiles branch from `57552d3` to `e1ef03a` Dec 13, 2018

rokaszygmantas force-pushed the rokaszygmantas:migration/employees_profiles branch from `8546440` to `0a2f886` Dec 21, 2018

rokaszygmantas commented Dec 21, 2018 •

edited

matks reviewed Jan 11, 2019

View changes

matks left a comment •

edited

rokaszygmantas force-pushed the rokaszygmantas:migration/employees_profiles branch from `c7ea4af` to `939bf0d` Jan 30, 2019

matks approved these changes Jan 30, 2019

View changes

matks merged commit `78501e2` into PrestaShop:develop Jan 30, 2019
1 check passed