New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow url in search preview to use several lines #10788

Merged
merged 2 commits into from Oct 2, 2018

Conversation

Projects
None yet
5 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 1, 2018

Questions Answers
Branch? 1.7.5.x
Description? Visual update on the search preview of the product page. When the URL is really long, the text overflew outside the div. It now us es several lines when needed.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Disable the URL rewriting in order to reproduce the issue. If the URL is long enough to go outside the div, get the PR and check the changes.

capture du 2018-10-01 11-26-19


This change is Reviewable

@LouiseBonnard

This comment has been minimized.

Contributor

LouiseBonnard commented Oct 1, 2018

@Quetzacoalt91, can you confirm there is no string to check in this PR? Just let me know and I will remove the waiting for wording label. ;-)

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 1, 2018

@LouiseBonnard I confirm there is no string to check ;)

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 1, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 970c9e2 into PrestaShop:1.7.5.x Oct 2, 2018

1 of 2 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:serp-url-display branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment