New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https only for API calls and limit use of guzzle #10795

Merged
merged 2 commits into from Oct 3, 2018

Conversation

Projects
None yet
6 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 1, 2018

Questions Answers
Branch? 1.7.5.x
Description? When module list is empty, avoid duplicating the calls to the Guzzle lib.
Type? bug fix
Category? CO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Fill the guzzle cache with empty data, then load the module page. You should see the number of calls decreasing. Note that even if the number is really high, it actually gets the data from a local cache.

Then:
capture du 2018-10-01 14-55-51
Now:
capture du 2018-10-01 15-08-05

Blackfire report: https://blackfire.io/profiles/compare/5ec005a2-4cbd-4f5e-ab3b-94d2f9956d4b/graph


This change is Reviewable

@eternoendless eternoendless added this to the 1.7.5.0 milestone Oct 1, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 2, 2018

@Quetzacoalt91 Quetzacoalt91 dismissed stale reviews from PierreRambaud and eternoendless via d878fd5 Oct 2, 2018

@Quetzacoalt91 Quetzacoalt91 removed the QA ✔️ label Oct 3, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Oct 3, 2018

Wow.

👍 👍 👍

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 3, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 118ef5d into PrestaShop:1.7.5.x Oct 3, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:use-https-only-and-limit-guzzle-calls branch Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment