New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse getAdminLink instead of copy pasting its content #10796

Merged
merged 1 commit into from Oct 2, 2018

Conversation

Projects
None yet
5 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 1, 2018

Questions Answers
Branch? 1.7.5.x
Description? It seems the content of getAdminLink has been copy pasted in the Adapter equivalent class. Because of the lack of
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? #10794
How to test? See issue.

This change is Reviewable

@marionf marionf added this to the 1.7.5.0 milestone Oct 1, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 1, 2018

@PierreRambaud PierreRambaud merged commit 20bcf2b into PrestaShop:1.7.5.x Oct 2, 2018

1 of 2 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 2, 2018

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:use-link-class-directly branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment