New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted URL to be SSL agnostic #10808

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
5 participants
@alu-

alu- commented Oct 2, 2018

Questions Answers
Branch? develop
Description? Specific usage of http:// in URL caused warnings in BO when using SSL
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Visit the BO with and without SSL/TLS.

This change is Reviewable

Oskar Andersson
@prestonBot

This comment has been minimized.

Collaborator

prestonBot commented Oct 2, 2018

Hello @alu-!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@alu-

This comment has been minimized.

alu- commented Oct 2, 2018

Hello @alu-!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Actually it is not. Where is the magic that makes you run, @prestonBot ?

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 2, 2018

@alu- It's maybe because of hypen :P

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Oct 2, 2018

@alu-

This comment has been minimized.

alu- commented Oct 2, 2018

apt-get install failed on one of the travis jobs. Not my fault, unsure if I can retrigger it myself or not.

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 2, 2018

Fixed!

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 9, 2018

@PierreRambaud PierreRambaud merged commit c3e5ceb into PrestaShop:develop Oct 10, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 10, 2018

Thanks @alu-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment