New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URL in search result preview to be live updated #10810

Merged
merged 2 commits into from Oct 10, 2018

Conversation

Projects
None yet
5 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 2, 2018

Questions Answers
Branch? 1.7.5.x
Description? Allow the URL in search preview to be live updated.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fixes #10756
How to test? Update the field Friendly URL in a product form, SEO tab

This change is Reviewable

@Quetzacoalt91 Quetzacoalt91 changed the title from Serp update url to Allow URL in search result preview to be live updated Oct 2, 2018

watchedMetaUrl.on('keyup change', (e) => {
serpComp.vm.$refs.serp.setUrl(
$('#product_form_preview_btn').data('redirect').replace(
initialValue, $('.serp-watched-url:input').val()

This comment has been minimized.

@PierreRambaud

PierreRambaud Oct 2, 2018

Contributor

$('.serp-watched-url:input') is already loaded with watchedMetaUrl

@marionf

This comment has been minimized.

Contributor

marionf commented Oct 9, 2018

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 9, 2018

@marionf I only have the URL for the default language, I can't implement it for the other languages yet. (The issue is the same for the name and description).

@PierreRambaud PierreRambaud merged commit b6cca13 into PrestaShop:1.7.5.x Oct 10, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 10, 2018

@eternoendless eternoendless added this to the 1.7.5.0 milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment