New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rebuild of SymfonyRequirements file after every composer run #10837

Merged
merged 2 commits into from Oct 3, 2018

Conversation

Projects
None yet
5 participants
@eternoendless
Member

eternoendless commented Oct 3, 2018

Questions Answers
Branch? 1.7.5.x
Description? We had to modify SymfonyRequirements.php to make it compatible with PHP 7.2 because Sensio won't. However, it was being overwritten by composer on each run. This PR stops it from being overwritten.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? No test needed

This change is Reviewable

@eternoendless eternoendless added this to the 1.7.5.0 milestone Oct 3, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Oct 3, 2018

wait!

you also need to remove the call in "post-install-cmd" block of composer

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 3, 2018

Done =)

@eternoendless

This comment has been minimized.

Member

eternoendless commented Oct 3, 2018

Nice catch @mickaelandrieu

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 3, 2018

Tests are failing. :)

@PierreRambaud PierreRambaud merged commit 2cdb333 into PrestaShop:1.7.5.x Oct 3, 2018

1 of 2 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 3, 2018

@eternoendless eternoendless deleted the eternoendless:remove-install-requirements-file branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment