New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error when saving product with tags #10856

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
5 participants
@rokaszygmantas
Contributor

rokaszygmantas commented Oct 4, 2018

Questions Answers
Branch? 1.7.5.x
Description? A bug was introduced in #10448, where incorrect variable names were used when saving product tags. Therefore you cannot save product if it has tags.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? Go to product edit form. Set some tags on the product, click save. With this PR you will be able to save it successfully, prior to this PR you would get an error "Unable to update settings.".

This change is Reviewable

@khouloudbelguith

This comment has been minimized.

Contributor

khouloudbelguith commented Oct 4, 2018

Related to: #9677

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Oct 9, 2018

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 9, 2018

Nice catch @rokaszygmantas

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 9, 2018

@PierreRambaud PierreRambaud merged commit ee8c1d2 into PrestaShop:1.7.5.x Oct 10, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment