New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed keywords disappear from search index #10859

Merged
merged 1 commit into from Nov 27, 2018

Conversation

Projects
None yet
9 participants
@marionf
Copy link
Contributor

marionf commented Oct 4, 2018

Questions Answers
Branch? 1.6.1.x
Description? Delete a product, and you delete words that is shared in search_word tabel, make other product disapear from search until next full reindex.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/PSCSX-8239
How to test? See ticket

This change is Reviewable

@marionf marionf changed the base branch from develop to 1.6.1.x Oct 4, 2018

@marionf marionf requested a review from jocel1 Oct 4, 2018

@marionf

This comment has been minimized.

Copy link
Contributor

marionf commented Oct 4, 2018

As #8587 is closed

@jocel1
Copy link
Contributor

jocel1 left a comment

LGTM (thanks @Casper-O !)

@eternoendless eternoendless dismissed stale reviews from PierreRambaud and jocel1 via ff5e0f4 Oct 9, 2018

@eternoendless eternoendless force-pushed the marionf:PSCSX-8239 branch from 0b9c321 to ff5e0f4 Oct 9, 2018

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Oct 9, 2018

Repushed for attribution... thanks @Casper-O

@eternoendless eternoendless added this to the 1.6.1.23 milestone Oct 9, 2018

@niccoX

This comment has been minimized.

Copy link

niccoX commented Oct 24, 2018

These tickets which many are from 2016/17, are still waiting to be merged. Why are they not added into 1.6, but keep being stalled? Even the author of this ticked seems quite angry and even closed the ticket. Way to go!

@ttoine

This comment has been minimized.

Copy link
Contributor

ttoine commented Nov 21, 2018

Hello @niccoX if you look at the recent releases of the 1.6.1.x, they were focused on security fixes.
When the team will have time again to release a 1.6 version for another reason that security, they will be able to work on this kind of pull request.

@niccoX

This comment has been minimized.

Copy link

niccoX commented Nov 21, 2018

Hello @niccoX if you look at the recent releases of the 1.6.1.x, they were focused on security fixes.
When the team will have time again to release a 1.6 version for another reason that security, they will be able to work on this kind of pull request.

Last update was 1 security fix.

@ttoine

This comment has been minimized.

Copy link
Contributor

ttoine commented Nov 21, 2018

but this was a lot of work and tests with the reporter of the issue.
also, you don't count that 3 security versions of the 1.6 have been released recently.

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Nov 27, 2018

Thanks @marionf

@eternoendless eternoendless changed the title Fixed keywords disapear from search index Fixed keywords disappear from search index Nov 27, 2018

@eternoendless eternoendless merged commit 9d2d639 into PrestaShop:1.6.1.x Nov 27, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless modified the milestones: 1.6.1.23, 1.6.1.24 Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment