New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fixed height of TinyMce fields #10861

Merged
merged 2 commits into from Oct 17, 2018

Conversation

Projects
None yet
6 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 4, 2018

Questions Answers
Branch? 1.7.5.x
Description? Partially reverts #10170 (ping @CaptainYouz ). Fixes the fixed height of the different text area on the product page
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fixes #10825
How to test? See issue, you need to write a lot of content in a product description.

This change is Reviewable

@CaptainYouz

This comment has been minimized.

Contributor

CaptainYouz commented Oct 4, 2018

Hi @Quetzacoalt91
Does this change reproduce the precedent behavior describe here #10170 ? If yes, better to set min-height value instead of getting rid of the height.

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 4, 2018

Which one are you thinking about? The only one related to this input is

    Increase dimensions of the text editor.
@CaptainYouz

This comment has been minimized.

Contributor

CaptainYouz commented Oct 4, 2018

@Quetzacoalt91 yep this one :)

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 4, 2018

Well, the issue I'm trying to fix is this input being too small, I'm following the changes requested.

@Quetzacoalt91 Quetzacoalt91 changed the title from Fix fixed height to Fix fixed height of TinyMce fields Oct 4, 2018

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 4, 2018

PR updated, we now use min-height instead of height !important

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 17, 2018

Rebased

@Quetzacoalt91 Quetzacoalt91 merged commit fbddfb1 into PrestaShop:1.7.5.x Oct 17, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:fix-fixed-height branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment