New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug when filter reset functionality sometimes does not work #10862

Merged
merged 2 commits into from Oct 5, 2018

Conversation

Projects
None yet
6 participants
@tomas862
Contributor

tomas862 commented Oct 4, 2018

Questions Answers
Branch? 1.7.5.x
Description? When you are using reset functionality in the new filter, it sometimes just does not work. 1/10 times. After the fix I included here, it now works always. So I suspect it cancels sometimes the POST request which was responsible for reseting the filters
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/prestafony-project#60
How to test? Go to any new list which has filters, try to reset filters until you notice that it did not made any change. Now do the same thing on this pull request - it should not happen.

This change is Reviewable

@sarjon

This comment has been minimized.

Member

sarjon commented Oct 4, 2018

@marionf remember issue when filters do not reset sometimes? this may be the fix. ;)

@Quetzacoalt91

Yeah, the POST request was probably canceled as soon as you tried to redirect.

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.5.0 milestone Oct 4, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 4, 2018

@PierreRambaud PierreRambaud merged commit 9eddf3f into PrestaShop:1.7.5.x Oct 5, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 5, 2018

Thanks @tomas862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment