New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date filtering in AdminSpecificPriceRuleController #10904

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
5 participants
@Matt75
Contributor

Matt75 commented Oct 8, 2018

Questions Answers
Branch? develop
Description? Unable to sort SpecificPrice by date in BO due to usage of reserved MySQL keywords
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #10876
How to test? Follow instruction given in issue #10876

This change is Reviewable

@Matt75

This comment has been minimized.

Contributor

Matt75 commented Oct 19, 2018

Fixed by #10991 👍

@Matt75 Matt75 closed this Oct 19, 2018

@Matt75

This comment has been minimized.

Contributor

Matt75 commented Oct 22, 2018

Reopen due to revert of #10991
#11111

@Matt75 Matt75 reopened this Oct 22, 2018

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 22, 2018

I wanted to prevent this kind of PR on each BO page, that's why I wanted a global fix at the first time.
Too bad it brings regressions at the same time.

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 23, 2018

@Matt75 Matt75 changed the base branch from develop to 1.7.5.x Oct 28, 2018

@Matt75 Matt75 changed the base branch from 1.7.5.x to develop Oct 28, 2018

@Matt75

This comment has been minimized.

Contributor

Matt75 commented Oct 29, 2018

@Quetzacoalt91 This PR should be merged in 1.7.5.x ?

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 29, 2018

Well, we made the whole process for the develop branch, I would now prefer to merge your PR immediately, even if it only makes it available for 1.7.6.0. :)

@Quetzacoalt91 Quetzacoalt91 removed the 1.7.5.x label Oct 29, 2018

@PierreRambaud PierreRambaud merged commit 242c8bb into PrestaShop:develop Nov 6, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Nov 6, 2018

Thanks @Matt75

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Nov 6, 2018

@eternoendless eternoendless changed the title from [BO] Fix date filtering in AdminSpecificPriceRuleController to Fix date filtering in AdminSpecificPriceRuleController Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment