New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build new theme using Webpack 4 #10911

Merged
merged 20 commits into from Jan 28, 2019

Conversation

@CaptainYouz
Copy link
Contributor

CaptainYouz commented Oct 8, 2018

Questions Answers
Branch? develop
Description? This PR migrate the new theme of BO to Webpack 4.
Type? improvement
Category? BO
BC breaks? yes
Deprecations? no
Fixed ticket? none
How to test? Everything in the new theme should work as before.

With this migration, three modes are now available:

  • npm run build: production mode
  • npm run build:analyze: production mode with bundler analyzer
  • npm run dev: development mode for the new theme

This change is Reviewable

@CaptainYouz CaptainYouz requested a review from eternoendless Oct 8, 2018

@CaptainYouz CaptainYouz force-pushed the CaptainYouz:webpack branch from 718444b to 434d0b5 Oct 22, 2018

@eternoendless eternoendless force-pushed the CaptainYouz:webpack branch from 434d0b5 to 6923cb3 Dec 19, 2018

@eternoendless eternoendless changed the title BO | New Theme: Migration to Webpack 4 Build new theme using Webpack 4 Dec 19, 2018

@eternoendless eternoendless added this to the 1.7.6.0 milestone Dec 19, 2018

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 19, 2018

Is this PR ready for review @eternoendless?

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Dec 19, 2018

I think it is. Just FYI there's an issue with live reload, I'm under the impression that exported images are missing when you use it. Also, I think we lost the source maps.

@PierreRambaud PierreRambaud self-requested a review Dec 19, 2018

@eternoendless
Copy link
Member

eternoendless left a comment

Don't forget to rebase, remove the previous commit containing compiled assets, build and commit them again.

Show resolved Hide resolved admin-dev/themes/new-theme/.webpack/dev.js Outdated

@PierreRambaud PierreRambaud force-pushed the CaptainYouz:webpack branch 2 times, most recently from dc1993e to c4cbe2a Dec 31, 2018

@eternoendless
Copy link
Member

eternoendless left a comment

LGTM

@PierreRambaud PierreRambaud force-pushed the CaptainYouz:webpack branch 2 times, most recently from d5c8de5 to a6f0a6e Jan 7, 2019

CaptainYouz and others added some commits Oct 8, 2018

Allow loading CSS files on symfony pages.
This is a workaround because legacylayout doesn't allow reaching
the head section of the html document.
Export product_page into its own bundle.
The live search engine preview (serp) component exports CSS and it's
used by the product page. When imported by the main bundle, it ended up
in main.css. Since it's now used by product_page, it goes into
product_page.css instead.

@PierreRambaud PierreRambaud force-pushed the CaptainYouz:webpack branch from a6f0a6e to 963aaae Jan 21, 2019

@jolelievre
Copy link
Contributor

jolelievre left a comment

Good job @PierreRambaud

@matks

matks approved these changes Jan 25, 2019

@ntiepresta ntiepresta self-assigned this Jan 28, 2019

@ntiepresta

This comment has been minimized.

Copy link

ntiepresta commented Jan 28, 2019

Hello,
after testing this Pr, everything works well as before, except for a few points as can be seen with the images below.
Before testing
normale
test with PR
should

@ntiepresta

This comment has been minimized.

Copy link

ntiepresta commented Jan 28, 2019

Before testing
config ok
test with PR
config should

@ntiepresta

This comment has been minimized.

Copy link

ntiepresta commented Jan 28, 2019

The user profile pop-up is not correctly displayed in the pages below

  1. SELL Orders( Invoies, Delivery slips);
    Catalog(products, stocks)

  2. IMPROVE Modules( Modules selections)
    Modules Manager( modules, alerts, updates)
    Design(theme & logo,)
    Positions
    Shipping(preferences)
    Payment(payment methods, preferences)
    International(localization, geolocation)
    Translations)

  3. Shop Parameters( General, maintenance)
    Order Setting( order setting)
    Product Setting
    Customer setting(customers)
    Traffic & SEO( Seo & urls)

  4. Advanced Parameters( Information)
    Performance
    Administtration
    E-mail
    import
    Database
    Logs.

Before testing
pop up profil ok
test with PR
profil should

Best regards,
Reddy Ntie

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 28, 2019

@ntiepresta Thank you for testing !

Since this PR has been hard to make and hard to rebase and the issues you reported are minor, we chose to merge this PR and handle your feedbacks in another PR. I'll take care of creating the right issue 😄

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 28, 2019

@matks matks merged commit a5fa3e7 into PrestaShop:develop Jan 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 28, 2019

QA reported issues have been listed here: #12333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment