New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getConfiguration to PrestaShopBundle #10917

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
4 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 8, 2018

Questions Answers
Branch? develop
Description? Add the getConfiguration method to make php bin/console debug:config PrestaShopBundle working.
Type? bug fix
Category? CO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Run php bin/console debug:config PrestaShopBundle. You should get the PrestaShop config.

Without PR:

$ php bin/console debug:config PrestaShopBundle
15:58:22 ERROR     [console] Error thrown while running command "debug:config PrestaShopBundle". Message: "The extension with alias "prestashop" does not have its getConfiguration() method setup" ["exception" => LogicException { …},"command" => "debug:config PrestaShopBundle","message" => "The extension with alias "prestashop" does not have its getConfiguration() method setup"] []

In AbstractConfigCommand.php line 108:
                                                                                           
  The extension with alias "prestashop" does not have its getConfiguration() method setup  
                                                                                           

debug:config [-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-n|--no-interaction] [-e|--env ENV] [--no-debug] [--id_shop [ID_SHOP]] [--id_shop_group [ID_SHOP_GROUP]] [--] <command> [<name>] [<path>]

With PR applied:

$ php bin/console debug:config PrestaShopBundle

Current configuration for "PrestaShopBundle"
============================================

prestashop:
    addons:
        prestatrust:
            enabled: true
        api_client:
            ttl: 300
            verify_ssl: /home/thomas/Documents/github/PrestaShop/var/cache/dev/cacert.pem

This change is Reviewable

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Oct 8, 2018

@PierreRambaud PierreRambaud merged commit 07dd65e into PrestaShop:develop Oct 9, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 9, 2018

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment