New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing class const on cert refresh #10921

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
6 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 8, 2018

Questions Answers
Branch? 1.6.1.x
Description? When the certificate used to make secure calls is refreshed, Tools use an undefined constant. This PR fixes a fatal error.
Type? bug fix
Category? CO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Refresh the certificate by removing the file /cache/cacert.pem.

This change is Reviewable

@eternoendless eternoendless added this to the 1.6.1.22 milestone Oct 9, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 9, 2018

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Oct 9, 2018

Thank you @Quetzacoalt91

@eternoendless eternoendless merged commit 20c006a into PrestaShop:1.6.1.x Oct 9, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SharakPL

This comment has been minimized.

Show comment
Hide comment
@SharakPL

SharakPL Oct 11, 2018

Why does it have to check outside url? What if this url stops responding (file moved, server down, etc.)? Won't it cause fatal error again? It doesn't seem like a proper fix.

SharakPL commented Oct 11, 2018

Why does it have to check outside url? What if this url stops responding (file moved, server down, etc.)? Won't it cause fatal error again? It doesn't seem like a proper fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment