New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow product import to change previous id_category_default when you force ID #10871 #10930

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
5 participants
@itisco
Contributor

itisco commented Oct 9, 2018

Questions Answers
Branch? develop
Description? Allow product import to change previous id_category_default when you force ID
Type? bug fix
Category? BO
BC breaks? no
Deprecations? yes - You no longer can just add categories to current categories with import to a force ID. You will have to set them all and the first will become the default_category.
Fixed ticket? #10871
How to test? Import products and force ID. The ID has to be an existing product with a different category from those imported. The category default should change now for the new one.

This change is Reviewable

@prestonBot

This comment has been minimized.

Collaborator

prestonBot commented Oct 9, 2018

Hello @itisco!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@itisco

This comment has been minimized.

Contributor

itisco commented Oct 9, 2018

Hum, what's the next step then ?

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 9, 2018

@itisco We need to wait for someone in our Quality team to test your Pull Request and check everything work fine :)

@itisco

This comment has been minimized.

Contributor

itisco commented Oct 9, 2018

@PierreRambaud Perfect, thanks ! If you have any questions, don't hesitate :)

@ntiepresta ntiepresta self-assigned this Oct 10, 2018

@ntiepresta ntiepresta removed their assignment Oct 11, 2018

@Quetzacoalt91

Applied php cs fixer

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Oct 16, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 7fe3d7d into PrestaShop:develop Oct 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 16, 2018

Thank you @itisco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment