New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad annotation in AttributeGroupLang, AttributeLang and TabLang #10939

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Projects
None yet
5 participants
@Fabuloops
Contributor

Fabuloops commented Oct 9, 2018

No more Column annotation with ManyToOne attribute
This commit fix my own issue #10937

Questions Answers
Branch? develop
Description? No need to use ORM\Column annotation with ManyToOne attribute association
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #10937
How to test? Try to persist and flush PrestaShopBundle\Entity\AttributeGroupLang entity

This change is Reviewable

Fix bad annotation in 3 Symfony Entity
No more @Orm\Column annotation with ManyToOne attribute
This commit fix my own issue #10937
@prestonBot

This comment has been minimized.

Collaborator

prestonBot commented Oct 9, 2018

Hello @Fabuloops!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added the Bug label Oct 9, 2018

@mickaelandrieu mickaelandrieu changed the title from Fix bad annotation in 3 Symfony Entity to Fix bad annotation in AttributeGroupLang, AttributeLang and TabLang Oct 11, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Oct 11, 2018

Thank you @Fabuloops and @dbadrukhiya for your help!

@mickaelandrieu mickaelandrieu merged commit 8239f3a into PrestaShop:develop Oct 11, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@prestonBot prestonBot added the develop label Oct 11, 2018

mickaelandrieu added a commit to mickaelandrieu/PrestaShop that referenced this pull request Oct 11, 2018

matks added a commit that referenced this pull request Oct 12, 2018

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment