New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow errors without field to be displayed on product form #10946

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
5 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 10, 2018

Questions Answers
Branch? 1.7.5.x
Description? Several validations are made during a product save: The Symfony Form validation and the legacy validation. The second one is unable to link an error to a specific field of the form, which makes the error not displayed. This PR adds a panel to display these details and make the merchant life easier.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Modify a product and copy paste an URL in the meta description field. The product cannot be saved, but you won't know why until you apply this PR.

capture du 2018-10-10 10-14-57


This change is Reviewable

@ntiepresta ntiepresta self-assigned this Oct 10, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Oct 10, 2018

@ntiepresta ntiepresta removed their assignment Oct 10, 2018

@PierreRambaud PierreRambaud merged commit 40dfec7 into PrestaShop:1.7.5.x Oct 10, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 10, 2018

@eternoendless eternoendless added this to the 1.7.5.0 milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment