New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in ajax quantity refresh #10964

Merged
merged 11 commits into from Nov 23, 2018

Conversation

Projects
None yet
6 participants
@damianobertuna

damianobertuna commented Oct 11, 2018

Questions Answers
Branch? 1.7.5.x
Description? Correction for Bug ajax quantity refresh #10948
Type? bug fix
Category? FO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? Fixes #10948
How to test? - Go to a product page with combination that have different minimum order quantity
- Click on a combination with minimum order quantity for instance 200, after choose a product with minimum order quantity setted to 100 and update manually the input field quantity to 100.
- In this situation it's impossible to add the combination to the cart.

This change is Reviewable

@prestonBot

This comment has been minimized.

Collaborator

prestonBot commented Oct 11, 2018

Hello @damianobertuna!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 11, 2018

Hi and thanks for the contribution. Look like you add some commits that are mustn't be in this pull request. Can you change it and target the 1.7.5.x branch please?

@damianobertuna

This comment has been minimized.

damianobertuna commented Oct 11, 2018

Hi and thanks for the contribution. Look like you add some commits that are mustn't be in this pull request. Can you change it and target the 1.7.5.x branch please?

Sorry, I'm not so skilled on github, could you tell me some tips about how to do?

@PierreRambaud PierreRambaud force-pushed the damianobertuna:MineDevPrestaShopBranch branch from 007d5c5 to 6e0a760 Oct 12, 2018

@PierreRambaud PierreRambaud changed the base branch from develop to 1.7.5.x Oct 12, 2018

@prestonBot prestonBot added the 1.7.5.x label Oct 12, 2018

@PierreRambaud PierreRambaud removed the develop label Oct 12, 2018

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 12, 2018

Hi @damianobertuna I fixed your branch and I commit to the real file which is themes/_core/js/product.js ;)

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Nov 12, 2018

@ntiepresta ntiepresta self-assigned this Nov 12, 2018

@ntiepresta

This comment has been minimized.

ntiepresta commented Nov 12, 2018

Hi,
This correction, resolves well problem described . But, displays this error, the field quantity have not been updated with minimum quantity. And impossible of decrease the quantity.
marion pro

https://drive.google.com/file/d/1fd1wDq-T_Ag4YlYAYcDfR8qutgOXl153/view?usp=sharing

@ntiepresta ntiepresta removed their assignment Nov 12, 2018

@marionf marionf self-assigned this Nov 23, 2018

@PierreRambaud PierreRambaud force-pushed the damianobertuna:MineDevPrestaShopBranch branch from 6e0a760 to a6aa39b Nov 23, 2018

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Nov 23, 2018

I logically fix errors :)

@PierreRambaud PierreRambaud force-pushed the damianobertuna:MineDevPrestaShopBranch branch from 6b5fb5a to 30c4445 Nov 23, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 23, 2018

@marionf marionf removed their assignment Nov 23, 2018

@PierreRambaud PierreRambaud merged commit 8110fdc into PrestaShop:1.7.5.x Nov 23, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Nov 23, 2018

@eternoendless eternoendless changed the title from Mine dev presta shop branch to Fix bug in ajax quantity refresh Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment