New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix General options configuration #10968

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Projects
None yet
7 participants
@sarjon
Member

sarjon commented Oct 11, 2018

Questions Answers
Branch? 1.7.5.x
Description? Fixes bug when "Increase front office security" and "Enable Multistore" options can be configured in any shop context.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Access "Configure > Shop Parameters > General" and you should be able to configure "Increase front office security" and "Enable Multistore" options only in "All shops" and single shop context with Multistore is disabled.

This change is Reviewable

@matks

This comment has been minimized.

Contributor

matks commented Oct 11, 2018

@BilalDr Did you know about this feature ?

@BilalDr

This comment has been minimized.

BilalDr commented Oct 11, 2018

@matks No, i didn't
Thanks

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 12, 2018

Should we accept this for the 1.7.5?

@sarjon

This comment has been minimized.

Member

sarjon commented Oct 12, 2018

Should we accept this for the 1.7.5?

any reason not to? :)

@BilalDr

This comment has been minimized.

BilalDr commented Oct 12, 2018

Disabling the configuration of the option "Increase front office security" in any shop context is useful.
Seen with @rGaillard, it's way better like this.

Thanks @sarjon

@matks matks added the migration label Oct 12, 2018

@matks

matks approved these changes Oct 15, 2018

@matks matks added this to the 1.7.5.0 milestone Oct 15, 2018

@matks

This comment has been minimized.

Contributor

matks commented Oct 15, 2018

For QA team: this is a feature we missed when we migrated this page. This is why we would like to merge it for 1.7.5 😃

@matks matks added this to In progress in PrestaShop 1.7.5 Oct 15, 2018

@matks matks moved this from In progress to To be reviewed in PrestaShop 1.7.5 Oct 15, 2018

@matks matks moved this from To be reviewed to To be tested in PrestaShop 1.7.5 Oct 15, 2018

@marionf marionf self-assigned this Oct 15, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 15, 2018

@marionf marionf removed their assignment Oct 15, 2018

@PierreRambaud PierreRambaud merged commit 37ca3ec into PrestaShop:1.7.5.x Oct 15, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 15, 2018

Thanks @sarjon

@sarjon sarjon deleted the sarjon:fix-general-preferences-config branch Oct 15, 2018

@matks matks removed this from To be tested in PrestaShop 1.7.5 Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment