New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced a new function for Products.php for retrive a product ID given it reference #10975

Merged
merged 1 commit into from Dec 14, 2018

Conversation

Projects
None yet
5 participants
@runningz
Copy link
Contributor

runningz commented Oct 11, 2018

Create new function for return the id product for a given reference

Questions Answers
Branch? develop
Description? I wrote a new function for Products.php for retrive a product ID given it reference.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
How to test? It's a internal (helper) function.. you can try calling Product::getIdByReference($reference)

This change is Reviewable

@mickaelandrieu mickaelandrieu changed the title Update classes/Product.php Introduced a new function for Products.php for retrive a product ID given it reference Dec 10, 2018

Update classes/Product.php
Create new function for return the id product for a given reference

@mickaelandrieu mickaelandrieu force-pushed the runningz:eKumba branch from 74200cc to f2b6507 Dec 10, 2018

@ntiepresta ntiepresta assigned ntiepresta and unassigned ntiepresta Dec 10, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Dec 10, 2018

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Dec 14, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit f19580b into PrestaShop:develop Dec 14, 2018

2 of 3 checks passed

code-review/reviewable 1 file left
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 14, 2018

Thank you @runningz

@runningz runningz deleted the runningz:eKumba branch Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment