New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change BO product list price source for multistore #10981

Merged
merged 1 commit into from Nov 27, 2018

Conversation

Projects
None yet
6 participants
@mafisz
Copy link
Contributor

mafisz commented Oct 12, 2018

Questions Answers
Branch? develop
Description? Previously price on the list was taken from product table and does not always match current store price. That price was the last updated price no metter which store was selected. Now price is taken from product_shop table and match current shop price.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Set up multistore with different currency for each one. Change price for product in first shop, change store and then price for second store and see the list. Price on the list show value from second store with second store currency sign. Now change back to first store. Price on the list show value from second store but with first store currency sign. After change price value for each store are correct.

This change is Reviewable

Change BO product list price source for multistore
Previously price on the list was taken from product table and does not always match current store price

Now price is taken from product_shop table and match current shop price
@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Oct 12, 2018

Hello @mafisz!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@mafisz mafisz closed this Oct 17, 2018

@mafisz mafisz reopened this Oct 17, 2018

@ntiepresta ntiepresta self-assigned this Nov 26, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 27, 2018

@marionf marionf added this to the 1.7.6.0 milestone Nov 27, 2018

@PierreRambaud PierreRambaud merged commit 9b8df4b into PrestaShop:develop Nov 27, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 27, 2018

Thanks @mafisz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment