New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asynchronous problem #11037

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
4 participants
@fatmaBouchekoua
Contributor

fatmaBouchekoua commented Oct 16, 2018

Questions Answers
Branch? 1.7.5.x
Description? Fix asynchronous problem when running all tests (one campaign)
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? You can run all full tests: npm run full-test -- --URL= URLFront --DIR=DownloadDirectory

This change is Reviewable

@fatmaBouchekoua

This comment has been minimized.

Contributor

fatmaBouchekoua commented Oct 17, 2018

@mbadrani review, please?

@mbadrani

I approve we will try launching all the campaign to definitely validate this PR

@mbadrani mbadrani merged commit 99f0cad into PrestaShop:1.7.5.x Oct 17, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless added this to the 1.7.5.0 milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment