New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CO: Update ambiguous code style #11043

Merged
merged 1 commit into from Nov 21, 2018

Conversation

Projects
None yet
3 participants
@gwarnants
Contributor

gwarnants commented Oct 17, 2018

Update ambigous code style

Questions Answers
Branch? 1.6.1.x
Description? else without brackets is not recommended (maintainability)
Type? refacto
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?

This change is Reviewable

Update CategoryController.php
Update ambigous code style
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Nov 21, 2018

It seems we don't need any QA review here. Merging.

@Quetzacoalt91 Quetzacoalt91 merged commit 9e499b3 into PrestaShop:1.6.1.x Nov 21, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 added this to the 1.6.1.24 milestone Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment