New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helper Card to Employees page #11049

Merged
merged 9 commits into from Nov 8, 2018

Conversation

Projects
None yet
7 participants
@sarjon
Member

sarjon commented Oct 17, 2018

Questions Answers
Branch? develop
Description? Adds helper card to employees page.
Type? new feature
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #10502 (comment)
How to test? Access admin-dev/index.php/configure/advanced/employees and you should see helper card at the very top.

This change is Reviewable

@matks matks added the migration label Oct 17, 2018

@sarjon sarjon changed the title from [WIP] Add Helper Card to Employees page to Add Helper Card to Employees page Oct 18, 2018

@sarjon

This comment has been minimized.

Member

sarjon commented Oct 18, 2018

ready for review. :)

@mickaelandrieu

Minor changes asked, the ping me so I can't add the Waiting for QA label.

Show resolved Hide resolved src/PrestaShopBundle/Resources/config/services/core/util/helper_card.yml Outdated
*#}
<div class="helper-card card">
<div class="helper-card__left helper-card__team shape-one">

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Oct 25, 2018

Contributor

I don't really like the mix between " - " and " __ ": please chose one and stick with it please.

This comment has been minimized.

@sarjon

sarjon Oct 25, 2018

Member

actually i didnt choose this style, i just reused it. :/ i believe this is some CSS coding style, but im not sure.

@matks

This comment has been minimized.

Contributor

matks commented Oct 30, 2018

@sarjon Code is fine 👍 but if you want to apply https://github.com/PrestaShop/PrestaShop/pull/11049/files#r225888094 it's even better

@sarjon sarjon force-pushed the sarjon:migrate/employee-helper-card branch from f104d7d to b729e55 Nov 5, 2018

@sarjon

This comment has been minimized.

Member

sarjon commented Nov 5, 2018

@matks updated it with https://github.com/PrestaShop/PrestaShop/pull/11049/files#r225888094 can you do a quick review again? :)

@matks matks added the waiting for QA label Nov 7, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 8, 2018

@matks

This comment has been minimized.

Contributor

matks commented Nov 8, 2018

@sarjon QA has validated, would you please rebase :) ?

@sarjon sarjon force-pushed the sarjon:migrate/employee-helper-card branch from b729e55 to ee8f56d Nov 8, 2018

@sarjon sarjon force-pushed the sarjon:migrate/employee-helper-card branch from ee8f56d to 2978a9a Nov 8, 2018

@sarjon

This comment has been minimized.

Member

sarjon commented Nov 8, 2018

done. 👍

@matks

This comment has been minimized.

Contributor

matks commented Nov 8, 2018

Thanks @sarjon

@matks matks added this to the 1.7.6.0 milestone Nov 8, 2018

@matks matks merged commit 1cb8047 into PrestaShop:develop Nov 8, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment