New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimum quantity blocking #11055

Merged
merged 3 commits into from Oct 25, 2018

Conversation

Projects
None yet
6 participants
@jolelievre
Contributor

jolelievre commented Oct 17, 2018

Questions Answers
Branch? 1.7.5.x
Description? remove useless function to get minimum quantity in favor of the working one
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #10984
How to test?

This change is Reviewable

*
* @return int
*/
protected function getMinimalProductOrDeclinationQuantity($product)

This comment has been minimized.

@PierreRambaud

PierreRambaud Oct 17, 2018

Contributor

Should be marked as deprecated instead

This comment has been minimized.

@jolelievre

jolelievre Oct 17, 2018

Contributor

since it's the only place where it is used, I don't see the interest of keeping it
it only increases the risk that somebody else tries to use it when it doesn't even work

This comment has been minimized.

@PierreRambaud

PierreRambaud Oct 17, 2018

Contributor

it's an old controller and it allows override :/ Someone is maybe using it/

This comment has been minimized.

@jolelievre

jolelievre Oct 18, 2018

Contributor

sh*** ^^ I forgot about the override Ok I put it back with a deprecated annotation

jolelievre added some commits Oct 18, 2018

@jolelievre

This comment has been minimized.

Contributor

jolelievre commented Oct 18, 2018

ok done @PierreRambaud

@tomlev

tomlev approved these changes Oct 23, 2018

@marionf marionf added the QA ✔️ label Oct 23, 2018

@jolelievre jolelievre merged commit 70b90dd into PrestaShop:1.7.5.x Oct 25, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.5.0 milestone Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment