New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hindi, Mexican & Bosnian languages #11058

Merged
merged 8 commits into from Nov 6, 2018

Conversation

Projects
None yet
6 participants
@PierreRambaud
Contributor

PierreRambaud commented Oct 18, 2018

Questions Answers
Branch? 1.7.5.x
Description? Include @LouiseBonnard Pull requests about Hindi, Mexican and Bosnian languages and add @eternoendless pull requests that add languages support.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
How to test? You must be able to install PrestaShop in Bosnian & Hindi.

This change is Reviewable

LouiseBonnard and others added some commits Aug 23, 2018

Fix typo
Fix typo

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Oct 18, 2018

@PierreRambaud PierreRambaud changed the title from Add Hindi & Bosnian languages to Add Hindi, Mexican & Bosnian languages Oct 19, 2018

@eternoendless

LGTM

@eternoendless

This comment has been minimized.

Member

eternoendless commented Oct 23, 2018

FYI: This PR also changes Filipino to Tagalog (because there's no 2-letter ISO code for Filipino) and adds Uzbek and Gujarati too

@marionf

This comment has been minimized.

Contributor

marionf commented Oct 23, 2018

If I select Hindi, it's not translated I still see English

capture d ecran_500

I don't see Mexican, Uzbek, Gujarati, Filipino or Tagalog in the list

If I install in bosnian language and Bosnia & Herzegovina country, the english is also installed with USD currency

capture d ecran_502

capture d ecran_501

@marionf

This comment has been minimized.

Contributor

marionf commented Oct 23, 2018

Don't know if it's related to this PR but if I switch to 1.7.5.x branch and try to re-install I have this error:

capture d ecran_503

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 23, 2018

@marionf For the first one, there is few translations in Hindi.
For the second, it's weird, I just installed PrestaShop with Hindi language :/

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Nov 6, 2018

@marionf I tried and I'm able to reproduce what you encounter. You switch source code, and in 1.7.5.x Hindi language is not yet available, so you have an index error :)
it's not related to this branch.

@Quetzacoalt91 Quetzacoalt91 merged commit 5a78318 into PrestaShop:1.7.5.x Nov 6, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Nov 6, 2018

Thank you @PierreRambaud

@PierreRambaud PierreRambaud deleted the PierreRambaud:add-languages branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment