New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PositionColumn to allow more route params #11063

Merged
merged 4 commits into from Oct 19, 2018

Conversation

Projects
None yet
6 participants
@jolelievre
Contributor

jolelievre commented Oct 18, 2018

Questions Answers
Branch? 1.7.5.x
Description? Improve PositionColumn you can now insert an array of parameters into the udpate_route (extracted from the grid result). This allow this extension to manage more use cases and the javascript code is simpler since it doesn't need to send the extra parameters like parentId (which are now in the url) and it focuses on what it needs to do, send the positions.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?

This change is Reviewable

*
* @return array
*/
public function extractArray(array $array, array $extractedKeys)

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Oct 18, 2018

Member

This reminds me of the Laravel Helper array_pluck: https://laravel.com/docs/5.7/helpers#method-array-pluck

This comment has been minimized.

@jolelievre

jolelievre Oct 18, 2018

Contributor

you're right, although the format is different and it only extract one field
do you want me to change the name? I wasn't 100% sure about the naming but I could not find any better one

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Oct 19, 2018

Thanks @jolelievre !

@jolelievre jolelievre merged commit d4daaa9 into PrestaShop:1.7.5.x Oct 19, 2018

1 of 2 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jolelievre jolelievre changed the title from improve PositionColumn to allow more route params to Improve PositionColumn to allow more route params Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment