New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces grid design update regarding grid wheel icon position and dropdown toggle icon modification #11095

Merged
merged 7 commits into from Nov 8, 2018

Conversation

Projects
None yet
8 participants
@tomas862
Member

tomas862 commented Oct 20, 2018

Questions Answers
Branch? develop
Description? As mentioned in #10774 (comment) some design changes are needed on all lists
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #11080 #11077
How to test? Check the design updates according to #10774 (comment) and also test if the list actions which are now located in list header works

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Oct 22, 2018

Hello @tomas862, how about some screenshots? 😄

@sarjon sarjon referenced this pull request Oct 23, 2018

Merged

Migrate customers listing #10916

@matks matks added the migration label Oct 23, 2018

@matks

This comment has been minimized.

Contributor

matks commented Oct 23, 2018

Here is the wheel :)
capture d ecran 2018-10-23 a 16 37 48

Here is the drop-down
capture d ecran 2018-10-23 a 16 38 12

@TristanLDD

This comment has been minimized.

TristanLDD commented Oct 30, 2018

Hello @matks, can you just adjust the position of the wheel in the header so it's vertically well centered?

wheel

Except this little detail I'm ok with these components :)

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Nov 6, 2018

@tomas862 Can you please fix conflicts and we will merge :)

@sarjon sarjon force-pushed the tomas862:features/grid-wheel-icon-position-and-dropdown-toggle-modification branch from 235c0ef to 112d748 Nov 7, 2018

@sarjon

This comment has been minimized.

Member

sarjon commented Nov 7, 2018

@PierreRambaud rebased. 😉

@matks

This comment has been minimized.

Contributor

matks commented Nov 7, 2018

@PierreRambaud @sarjon Did Tristan's UX feedback got implemented ? I tried to do it but I'm really bad at CSS 😞

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Nov 7, 2018

@matks Tristran removed the waiting for UX label 8 days ago :) so should be ok now!

@matks

This comment has been minimized.

Contributor

matks commented Nov 7, 2018

Travis is not happy because of lint

@sarjon

This comment has been minimized.

Member

sarjon commented Nov 7, 2018

lint was fixed by this PR #11306 so it is not because of this PR, but i can rebase if you want. :)

@matks

This comment has been minimized.

Contributor

matks commented Nov 7, 2018

@sarjon thanks but this is not required: if develop branch is fine now, I can restart travis build and it should be green

@sarjon

This comment has been minimized.

Member

sarjon commented Nov 7, 2018

it should be green

and it is. :)

@PierreRambaud PierreRambaud merged commit cc3f236 into PrestaShop:develop Nov 8, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Nov 8, 2018

Thanks @sarjon

@matks matks added this to the 1.7.6.0 milestone Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment