New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix discount display without tax #11103

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
6 participants
@tomlev
Copy link
Member

tomlev commented Oct 22, 2018

Questions Answers
Branch? develop
Description? Fix discount display when display preference is set without tax
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? #9696
How to test? create a product with specific price (should display discount on productpage / cart). Set customer group preference to display prices without tax. The original price and the discount amount will now be displayed without tax

This change is Reviewable

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Nov 26, 2018

How about an automated test to go with this fix? 😁

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 27, 2018

@PierreRambaud PierreRambaud merged commit e87de7c into PrestaShop:develop Nov 28, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 28, 2018

Thanks @tomlev

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment