New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Apply quotes around the column names would make all the SQL r… #11111

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
4 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 22, 2018

Questions Answers
Branch? 1.7.5.x
Description? I requested changes on #10991 which makes the webservice page crash. This PR reverts the specific commit.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fixes #11109
How to test? Reach webservice page

This change is Reviewable

@jolelievre

too bad we can't use the general fix..

@jolelievre

This comment has been minimized.

Contributor

jolelievre commented Oct 23, 2018

thank you @Quetzacoalt91

@jolelievre jolelievre merged commit 0161dc4 into PrestaShop:1.7.5.x Oct 23, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:webservice-access branch Oct 23, 2018

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.5.0 milestone Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment