New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some fixes to the campaign Full #11122

Merged
merged 2 commits into from Oct 29, 2018

Conversation

Projects
None yet
6 participants
@YosraAk

YosraAk commented Oct 23, 2018

Questions Answers
Branch? 1.7.5.x
Description? Add some fixes to the campaign Full
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? Run this command: npm run full-test -- --URL=ShopURL

This change is Reviewable

yosra.akrout
@prestonBot

This comment has been minimized.

Collaborator

prestonBot commented Oct 23, 2018

Hello @YosraAk!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

client.waitForExistAndClick(AddProductPage.preview_link)
}
})
});

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Oct 23, 2018

Member

I see this code written two times. You should move this code in a common secnario file, and call it from here.

client.waitForExistAndClick(AddProductPage.preview_link)
}
})
});

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Oct 23, 2018

Member

I see this code written two times. You should move this code in a common secnario file, and call it from here.

yosra.akrout
@YosraAk

This comment has been minimized.

YosraAk commented Oct 23, 2018

Hi @Quetzacoalt91 ,
Done. Thanks for your review.

@fatmaBouchekoua

This comment has been minimized.

Contributor

fatmaBouchekoua commented Oct 25, 2018

@mbadrani this PR is ready for merge

@mbadrani mbadrani merged commit 3d28149 into PrestaShop:1.7.5.x Oct 29, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@matks matks added this to the 1.7.5.0 milestone Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment