New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the E2E tests wait for the first load of the BO with welcome module enabled #11123

Merged
merged 3 commits into from Oct 23, 2018

Conversation

Projects
None yet
5 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 23, 2018

Questions Answers
Branch? 1.7.5.x
Description? Make the E2E script wait for the welcome modal, instead of closing / reopening the browser. Also, refactoed all calls to the welcome modal.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? E2E tests in Travis remains green.

This change is Reviewable

@Quetzacoalt91 Quetzacoalt91 changed the title from E2e test welcome module to Make the E2E tests waiting for the first load of the BO with welcome module enabled Oct 23, 2018

@eternoendless eternoendless changed the title from Make the E2E tests waiting for the first load of the BO with welcome module enabled to Make the E2E tests wait for the first load of the BO with welcome module enabled Oct 23, 2018

@eternoendless eternoendless added the TE label Oct 23, 2018

@eternoendless eternoendless added this to the 1.7.5.0 milestone Oct 23, 2018

@jolelievre jolelievre merged commit 7a079d7 into PrestaShop:1.7.5.x Oct 23, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment