New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed inline-style of color in demo product desciption of "Hummingbi… #11133

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
5 participants
@dineshbadrukhiya
Contributor

dineshbadrukhiya commented Oct 24, 2018

Questions Answers
Branch? develop
Description? Removed inline-style of color in demo product desciption of "Hummingbird_printed_t-shirt" for design improvement.
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11211
How to test? Go to: http://demo.prestashop.com/en/?view=front ,Where on product page of "Hummingbird_printed_t-shirt" font color should be consistence in description tab.

This change is Reviewable

Remove inline-style of color in demo product desciption of "Hummingbi…
…rd_printed_t-shirt"

Remove inline-style of color in demo product desciption of "Hummingbird_printed_t-shirt"

@dineshbadrukhiya dineshbadrukhiya changed the title from Remove inline-style of color in demo product desciption of "Hummingbi… to Removed inline-style of color in demo product desciption of "Hummingbi… Oct 24, 2018

@dineshbadrukhiya

This comment has been minimized.

Contributor

dineshbadrukhiya commented Oct 29, 2018

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 31, 2018

Yep, it needs to be updated. I also found out that all languages have this issue. cc @LouiseBonnard

@dineshbadrukhiya

This comment has been minimized.

Contributor

dineshbadrukhiya commented Oct 31, 2018

Hello @Quetzacoalt91
I think it should be updated for 1.7.5.0 also.

@MathiasReker

This comment has been minimized.

Contributor

MathiasReker commented Oct 31, 2018

How about remove all the inline style? For some time ago I removed the font from the inline style (https://github.com/PrestaShop/PrestaShop/pull/10867/files) I think that it is better to remove all the inline style at once.

@dineshbadrukhiya

This comment has been minimized.

Contributor

dineshbadrukhiya commented Oct 31, 2018

Hello @Quetzacoalt91

Does I need to remove this inline-style for all other languages?

@MathiasReker

This comment has been minimized.

Contributor

MathiasReker commented Oct 31, 2018

@dbadrukhiya you can see what I mean here: #11212

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 31, 2018

Well, if you don't mind @dbadrukhiya I'd appreciate. :)
Let's stick to the develop branch for this PR.

@dineshbadrukhiya

This comment has been minimized.

Contributor

dineshbadrukhiya commented Oct 31, 2018

Np @Quetzacoalt91 , I will remove it for othe languages also.

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 31, 2018

I missed it the first time, but it seems @MathiasReker already made a PR about this.

@dineshbadrukhiya

This comment has been minimized.

Contributor

dineshbadrukhiya commented Oct 31, 2018

That’s great! @Quetzacoalt91 . Is it good decision to remove all inline styles? Wdyt?

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 31, 2018

Well, as I said in #11212 (comment), I'm unsure about removing everything, as these field will end anyway with inline style as soon as they are updated. I'd like to start first with the color.

@dineshbadrukhiya

This comment has been minimized.

Contributor

dineshbadrukhiya commented Oct 31, 2018

I’m also unsure with removing all. Can I start with color @Quetzacoalt91 ?

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 31, 2018

I let you decide. Just avoid doing the same work 2 times with @MathiasReker . 😉

@dineshbadrukhiya

This comment has been minimized.

Contributor

dineshbadrukhiya commented Nov 1, 2018

Hello @Quetzacoalt91
I have opened new PR #11215 to start first with inline-style of color.

@Quetzacoalt91 Quetzacoalt91 merged commit 06a3fcd into PrestaShop:develop Nov 6, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment