New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate legacy Db service #11139

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
3 participants
@sarjon
Member

sarjon commented Oct 24, 2018

Questions Answers
Branch? develop
Description? Deprecates use of legacy Db service.
Type? improvement
Category? CO
BC breaks? no
Deprecations? yes
Fixed ticket? n/a
How to test? When used it will be displayed in profiler like so: https://prnt.sc/l9tlts

This change is Reviewable

@sarjon

This comment has been minimized.

Member

sarjon commented Oct 24, 2018

ping @matks

@matks

matks approved these changes Oct 24, 2018

@matks

This comment has been minimized.

Contributor

matks commented Oct 24, 2018

Cannot be easily tested by QA. As it is an optional tech feature (it helps developers to know what not-to-use) I think we can skip QA :)

@matks matks added the migration label Oct 24, 2018

@matks matks added this to the 1.7.6.0 milestone Oct 24, 2018

@matks matks merged commit 74f471d into PrestaShop:develop Oct 24, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matks

This comment has been minimized.

Contributor

matks commented Oct 24, 2018

Thanks @sarjon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment