New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CO : Remove unreachable code #11140

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
4 participants
@idnovate
Contributor

idnovate commented Oct 24, 2018

Questions Answers
Branch? develop
Description? $type can never be cart_rule because it's evaluated in previous if
Type? improvement
Category? CO
BC breaks? No
Deprecations? No

This change is Reviewable

@matks

This comment has been minimized.

Contributor

matks commented Oct 24, 2018

Makes sense 👍

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Oct 26, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Oct 26, 2018

Thanks @idnovate !

@mickaelandrieu mickaelandrieu merged commit 5274f06 into PrestaShop:develop Oct 26, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment