New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of "Catalog > Brand & Suppliers > Suppliers" listing #11153

Merged
merged 69 commits into from Jan 11, 2019

Conversation

@tomas862
Copy link
Member

tomas862 commented Oct 25, 2018

Questions Answers
Branch? develop
Description? supplier list can be reached via admin-dev/index.php/sell/catalog/suppliers/
Type? new feature
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #10545
How to test? The list should work exactly the same just that the "Add", "View" and "Edit" links will point to legacy suppliers form page. Needs assets to be rebuilt.

This change is Reviewable

@matks matks added the migration label Oct 29, 2018

@tomas862 tomas862 force-pushed the tomas862:migration-brands-and-suppliers-list branch 2 times, most recently from 2922ba7 to d79847c Nov 22, 2018

@tomas862 tomas862 changed the title [WIP] Migration of "Catalog > Brand & Suppliers > Suppliers" listing Migration of "Catalog > Brand & Suppliers > Suppliers" listing Nov 29, 2018

@tomas862

This comment has been minimized.

Copy link
Member Author

tomas862 commented Nov 29, 2018

@matks ready for review 🙂

@matks
Copy link
Contributor

matks left a comment

Hello @tomas862 nice work ! A few minor feedbacks here 😃

@matks matks referenced this pull request Dec 12, 2018

Open

Migrate "Catalog > Brand & Suppliers > Suppliers" page #10545

1 of 2 tasks complete

@tomas862 tomas862 force-pushed the tomas862:migration-brands-and-suppliers-list branch from 904cc4b to a0c9b82 Dec 14, 2018

@tomas862

This comment has been minimized.

Copy link
Member Author

tomas862 commented Dec 14, 2018

added some changes regarding the feedback! 👍

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 14, 2018

@tomas862 great !
Let's get QA approval and only then rebase 😄

@marionf

This comment has been minimized.

Copy link
Contributor

marionf commented Dec 17, 2018

Hello @tomas862

When I click on import I have this error:

capture d ecran_781

@TristanLDD is it ok for you ?

capture d ecran_783

@tomas862

This comment has been minimized.

Copy link
Member Author

tomas862 commented Dec 17, 2018

Hi @marionf

About the error - the problem happens on import page so its totally not related with current pull request. Someone will fix that error on separate pull request

@tomas862 tomas862 force-pushed the tomas862:migration-brands-and-suppliers-list branch from 52e1790 to e11bb2d Jan 8, 2019

@tomas862

This comment has been minimized.

Copy link
Member Author

tomas862 commented Jan 9, 2019

Changes made:

  • Vertically align the pagination system components:
    pagination_text

  • adds placeholders (except for active selector @matks will inform me if we will do that)
    placeholders

  • for moving search button to the right - #11877 has to be merged first ;)

@marionf marionf added QA ✔️ and removed waiting for author labels Jan 9, 2019

@matks

matks approved these changes Jan 11, 2019

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 11, 2019

Thanks @tomas862

@matks matks merged commit fc5da24 into PrestaShop:develop Jan 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless added this to the 1.7.6.0 milestone Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment