New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AdminProductsController.php #11175

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
None yet
6 participants
@simondaigre
Copy link
Contributor

simondaigre commented Oct 29, 2018

This PR allows product default supplier reference to be updated, if the product supplier is already attached to the product.

Questions Answers
Branch? develop
Description? Update product supplier reference whatever product supplier is new or not.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Create a product, add a product supplier with reference, edit supplier reference

This change is Reviewable

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Oct 29, 2018

Hello @simondaigre!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@simondaigre

This comment has been minimized.

Copy link
Contributor Author

simondaigre commented Dec 20, 2018

Hi @mickaelandrieu,

Could you merge this PR ?

Thanks

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 22, 2018

Hi @simondaigre , can you apply a cs fixer please?
To run the command:
./vendor/bin/php-cs-fixer fix

@Quetzacoalt91 Quetzacoalt91 force-pushed the simondaigre:product-supplier-issue branch from 5fc6b14 to 171ced5 Jan 28, 2019

@Quetzacoalt91
Copy link
Member

Quetzacoalt91 left a comment

Rebased, ammended the commit title & applied cs fixer.

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Jan 28, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit 0b835e3 into PrestaShop:develop Jan 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 28, 2019

Thank you @simondaigre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment