New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced localization #11184

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
5 participants
@ansar21mallouli
Contributor

ansar21mallouli commented Oct 30, 2018

Questions Answers
Branch? develop
Description? Update language identifier and country identifier in localization
Type? new feature
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? TEST_PATH=full/11_international/1_localization/1_localization/4_advanced npm run specific-test -- --URL=URLFrontOffice

This change is Reviewable

@prestonBot

This comment has been minimized.

Collaborator

prestonBot commented Oct 30, 2018

Hello @ansar21mallouli!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@ansar21mallouli ansar21mallouli changed the title from TE: advanced to Advanced localization Oct 30, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Nov 7, 2018

LGTM, thanks @ansar21mallouli and everyone for the reviews

@mickaelandrieu mickaelandrieu merged commit d4add61 into PrestaShop:develop Nov 7, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment