New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug where PrestaShop cookie is set on every page when a cookie value is NULL #11202

Merged
merged 2 commits into from Nov 12, 2018

Conversation

Projects
None yet
5 participants
@jocel1
Contributor

jocel1 commented Oct 30, 2018

Questions Answers
Branch? develop
Description? fix a bug where PrestaShop cookie is set on every page when a cookie content value associated with a key is NULL
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Difficult to test. A new prestashop Cookie entry need to be set with a NULL value. At the first load, the PrestaShop cookie will be set (since it wasn't existing at all). At the second load, the cookie should NOT be set since the NULL has not changed.

This change is Reviewable

@jocel1 jocel1 requested a review from eternoendless Oct 30, 2018

@jocel1 jocel1 self-assigned this Oct 30, 2018

@jocel1 jocel1 added this to the 1.7.6.0 milestone Oct 30, 2018

@jocel1 jocel1 requested a review from mickaelandrieu Oct 30, 2018

@prestamodule

This comment has been minimized.

Contributor

prestamodule commented Nov 5, 2018

@jocel1 if it's a bug, milestone should be changed, WDYT ?

@jocel1

This comment has been minimized.

Contributor

jocel1 commented Nov 5, 2018

@prestamodule it's not a new regression, it's there even in 1.6 so it should be in the next milestone. BTW it only impacts potential modules which could set suck NULL cookie values.

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 8, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 9d25927 into PrestaShop:develop Nov 12, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Nov 12, 2018

Thank you @jocel1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment