New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[*] CO : Fixed incorrect comparison when out of stock #11204

Merged
merged 1 commit into from Nov 22, 2018

Conversation

Projects
None yet
5 participants
@andromaque
Contributor

andromaque commented Oct 30, 2018

Questions Answers
Branch? develop
Description? When a product['quantity_wanted'] > 0 and product['quantity'] == 0, we should not display 'There are not enough products in stock' but the regular message set up in the BO
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #10893
How to test? Put a quantity to 0 for a product. The message displayed should be the OOS message defined in the BO, not "There are not enough products in stock" message.

This change is Reviewable

Fixed incorrect comparison when out of stock
Referenced in #10893
When a product['quantity_wanted'] > 0 and product['quantity'] == 0, we should not display 'There are not enough products in stock' but the regular message set up in the BO
@prestonBot

This comment has been minimized.

Collaborator

prestonBot commented Oct 30, 2018

Hello @andromaque!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Nov 21, 2018

@marionf marionf self-assigned this Nov 21, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 22, 2018

@marionf marionf removed their assignment Nov 22, 2018

@PierreRambaud PierreRambaud merged commit 740b731 into PrestaShop:develop Nov 22, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Nov 22, 2018

Thanks @andromaque

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment