Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect comparison when out of stock #11204

Merged
merged 1 commit into from Nov 22, 2018
Merged

Fix incorrect comparison when out of stock #11204

merged 1 commit into from Nov 22, 2018

Conversation

andromaque
Copy link
Contributor

@andromaque andromaque commented Oct 30, 2018 •
edited by eternoendless

Questions Answers
Branch? develop
Description? When a product['quantity_wanted'] > 0 and product['quantity'] == 0, we should not display 'There are not enough products in stock' but the regular message set up in the BO
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #10893
How to test? Put a quantity to 0 for a product. The message displayed should be the OOS message defined in the BO, not "There are not enough products in stock" message.

This change is Reviewable

@andromaque
Fixed incorrect comparison when out of stock
5e58285 
Referenced in #10893
When a product['quantity_wanted'] > 0 and product['quantity'] == 0, we should not display 'There are not enough products in stock' but the regular message set up in the BO
@prestonBot
Copy link
Collaborator

Hello @andromaque!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added develop Branch Bug Type: Bug labels Oct 30, 2018
@khouloudbelguith khouloudbelguith mentioned this pull request Oct 31, 2018
Closed
@mickaelandrieu mickaelandrieu added the Waiting for QA Status: action required, waiting for test feedback label Nov 21, 2018
@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Nov 21, 2018
@marionf marionf self-assigned this Nov 21, 2018
@marionf marionf added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 22, 2018
@marionf marionf removed their assignment Nov 22, 2018
@PierreRambaud PierreRambaud merged commit 740b731 into PrestaShop:develop Nov 22, 2018
@PierreRambaud
Copy link
Contributor

Thanks @andromaque

@eternoendless eternoendless changed the title [*] CO : Fixed incorrect comparison when out of stock Fix incorrect comparison when out of stock Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickaelandrieu mickaelandrieu mickaelandrieu approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.6.0
Development

Successfully merging this pull request may close these issues.

Product availability_message incorect if order out of stock products is disabled
5 participants
@andromaque @prestonBot @PierreRambaud @mickaelandrieu @marionf