New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved survival tests #11237

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
3 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Nov 2, 2018

Questions Answers
Branch? develop
Description? Thinking about it, I just remembered a super useful feature of Symfony πŸ‘
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
How to test? Nothing to do: accept it or not if you think it's useful.

Before (useless test result)

➜  PrestaShop git:(develop) βœ— ./vendor/bin/phpunit -c tests/phpunit-admin.xml --filter=SurvivalTest
PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

F......................                                           23 / 23 (100%)

Time: 3.06 seconds, Memory: 164.50MB

There was 1 failure:

1) Tests\Integration\PrestaShopBundle\Controller\Admin\SurvivalTest::testPagesAreAvailable with data set "administration_page" ('Administration', 'admin_administration')
Administration page should be available, but status code is 500
Failed asserting that false is true.

After (useful test result)

➜  PrestaShop git:(develop) βœ— ./vendor/bin/phpunit -c tests/phpunit-admin.xml --filter=SurvivalTest
PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

E......................                                           23 / 23 (100%)

Time: 1.52 seconds, Memory: 146.50MB

There was 1 error:

1) Tests\Integration\PrestaShopBundle\Controller\Admin\SurvivalTest::testPagesAreAvailable with data set "administration_page" ('Administration', 'admin_administration')
PrestaShop\PrestaShop\Core\Foundation\IoC\Exception: BOOM

/home/dev/Projects/PrestaShop/src/PrestaShopBundle/Controller/Admin/Configure/AdvancedParameters/AdministrationController.php:59
/home/dev/Projects/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php:151
/home/dev/Projects/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php:68
/home/dev/Projects/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php:200
/home/dev/Projects/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Client.php:68
/home/dev/Projects/PrestaShop/vendor/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/Client.php:131
/home/dev/Projects/PrestaShop/vendor/symfony/symfony/src/Symfony/Component/BrowserKit/Client.php:312
/home/dev/Projects/PrestaShop/tests/Integration/PrestaShopBundle/Controller/Admin/SurvivalTest.php:86

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Nov 2, 2018

Also, this will helps a lot for errors that come from Twig 2 build! /c @sarjon

This could be add in any functional tests but I don't have time "today" to introduce this change.

@mickaelandrieu mickaelandrieu force-pushed the mickaelandrieu:improve-survival-tests branch from 6897e6f to f2a01a8 Nov 5, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit a0ea1ba into PrestaShop:develop Nov 5, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment