New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 10962: Replace deprecated library PhpExcel by PhpSpreadsheet #11246

Merged
merged 9 commits into from Nov 6, 2018

Conversation

Projects
None yet
5 participants
@MartinFinkenflugel
Contributor

MartinFinkenflugel commented Nov 2, 2018

Questions Answers
Branch? develop
Description? Replaced all usage of PHPExcel by PHPSpreadsheet
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #10962
How to test? Import an XLS or XLSX file from the admin view

This change is Reviewable

@prestonBot

This comment has been minimized.

Collaborator

prestonBot commented Nov 2, 2018

Hello @MartinFinkenflugel!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

MartinFinkenflugel added some commits Nov 2, 2018

@Quetzacoalt91

Thank you for replacing the lib. Here a few changes to bring regarding the namespace declaration.

Show resolved Hide resolved controllers/admin/AdminImportController.php Outdated
Show resolved Hide resolved controllers/admin/AdminImportController.php Outdated
Show resolved Hide resolved src/Adapter/Converter/ExcelToCsvFileConverter.php Outdated
Show resolved Hide resolved src/Adapter/Converter/ExcelToCsvFileConverter.php Outdated
Show resolved Hide resolved src/Adapter/Converter/ExcelToCsvFileConverter.php Outdated

Quetzacoalt91 and others added some commits Nov 2, 2018

Update src/Adapter/Converter/ExcelToCsvFileConverter.php
Co-Authored-By: MartinFinkenflugel <1516225+MartinFinkenflugel@users.noreply.github.com>
Update src/Adapter/Converter/ExcelToCsvFileConverter.php
Co-Authored-By: MartinFinkenflugel <1516225+MartinFinkenflugel@users.noreply.github.com>
Update src/Adapter/Converter/ExcelToCsvFileConverter.php
Co-Authored-By: MartinFinkenflugel <1516225+MartinFinkenflugel@users.noreply.github.com>

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 6, 2018

@PierreRambaud PierreRambaud merged commit 607c7c7 into PrestaShop:develop Nov 6, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Nov 6, 2018

Thanks a lot @MartinFinkenflugel

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment