New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix declaration of method arguments #11249

merged 1 commit into from Nov 5, 2018


None yet
3 participants

Seleda commented Nov 2, 2018

Questions Answers
Branch? develop
Description? In the database structure, these fields are declared as follows: id_product_attribute int(10) unsigned NOT NULL DEFAULT '0', id_customization int(10) unsigned NOT NULL DEFAULT '0'.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
How to test? If you call a method without these arguments, the index is " $id_product.'- ' .$id_product_attribute" of the array "$preservedGifts" at line 1653 will not be correct.

This change is Reviewable


This comment has been minimized.


mickaelandrieu commented Nov 5, 2018

Thank you @Seleda!

@mickaelandrieu mickaelandrieu added this to the milestone Nov 5, 2018

@mickaelandrieu mickaelandrieu merged commit a643402 into PrestaShop:develop Nov 5, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment