New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inconsistent locale in Front Office #11261

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
4 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Nov 5, 2018

Questions Answers
Branch? 1.7.5.x
Description? Even when we chose a locale using the Language Selector in Front Office, in some pages the default locale was used
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11141
How to test? You'd better read the related issue ;)

This change is Reviewable

@marionf marionf assigned marionf and unassigned marionf Nov 5, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 6, 2018

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Nov 6, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Nov 6, 2018

LGTM, thanks everyone for the reviews.

@mickaelandrieu mickaelandrieu merged commit 7eb300d into PrestaShop:1.7.5.x Nov 6, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:fix-11141-inconsistent-locale-in-FO branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment