Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow BO hooks to use the method $this->render() #11266

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Quetzacoalt91
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 commented Nov 5, 2018

Questions Answers
Branch? develop
Description? Allow BO hooks to use the method $this->render()
Type? improvement
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fixes #11230
How to test? Add ps_homeslider on the hook displayAdminAfterHeader. Its content should be displayed on each BO page, although this is front-office content.

This change is Reviewable

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Nov 5, 2018
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Nov 6, 2018
@marionf marionf added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 6, 2018
@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Nov 7, 2018
@PierreRambaud PierreRambaud merged commit 53fbd50 into PrestaShop:develop Nov 7, 2018
@PierreRambaud
Copy link
Contributor

Thanks @Quetzacoalt91

@eternoendless eternoendless changed the title $this->fetch() can return content in BO context Allow BO hooks to use the method $this->render() Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants