New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert customization price to current currency #11282

Merged
merged 1 commit into from Nov 27, 2018

Conversation

Projects
None yet
6 participants
@unlocomqx
Copy link
Contributor

unlocomqx commented Nov 6, 2018

Questions Answers
Branch? develop
Description? The customization price should be converted to give a correct total
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
How to test? Create a customization then change its price in the database (usually it's done by a module which adds options to a product). Then change the currency, the total should be correct

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Nov 21, 2018

Hello @unlocomqx,

you can fix your pull request executing this command in the root folder of your shop:

./vendor/bin/php-cs-fixer fix

Regards

@unlocomqx unlocomqx force-pushed the unlocomqx:customization-price branch from 1fd9b22 to 817c9c6 Nov 21, 2018

@unlocomqx unlocomqx force-pushed the unlocomqx:customization-price branch from 817c9c6 to ac98782 Nov 21, 2018

@unlocomqx

This comment has been minimized.

Copy link
Contributor

unlocomqx commented Nov 21, 2018

I rebased and reformatted my code, now the linter is green

Thank you

@marionf marionf self-assigned this Nov 26, 2018

@marionf

This comment has been minimized.

Copy link
Contributor

marionf commented Nov 27, 2018

Hello @unlocomqx
I can't reproduce the issue, can you please send a screeshot showing the problem ?
When I edit the price in product table, the price isn't updated in the product page in BO & FO it still show the old price
Than you !

@unlocomqx

This comment has been minimized.

Copy link
Contributor

unlocomqx commented Nov 27, 2018

Hi @marionf , here's the list of steps to reproduce, I will send you more info if anything isn't clear

  1. Create a text customization field in the Options tab of the product edit page
    https://scr.prestalife.net/sc6a8c4
  2. Fill the field in the product page then save it and add it to cart
    https://scr.prestalife.net/sc0d8r8
  3. Change the customization price in the table "customized_data" (this step is supposed to be performed by a module)
    https://scr.prestalife.net/sc0m8i4
  4. The total should reflect the product price + customization price
    https://scr.prestalife.net/sc6h8p5
  5. Change the currency in the cart page (I use a conv rate of 10 to simplify)
    https://scr.prestalife.net/sc4b2v9
  6. The product price is converted but the customization price isn't converted which makes the total wrong
    https://scr.prestalife.net/sc9r2z1

Best regards

@marionf

This comment has been minimized.

Copy link
Contributor

marionf commented Nov 27, 2018

Thank you for these details @unlocomqx
I can reproduce the issue and your PR solve it 👍

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 27, 2018

@marionf marionf removed their assignment Nov 27, 2018

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Nov 27, 2018

@PierreRambaud PierreRambaud merged commit 5b20bed into PrestaShop:develop Nov 27, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 27, 2018

Thanks @unlocomqx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment