New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on tab unregistration when handled by the module #11300

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
5 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Nov 7, 2018

Questions Answers
Branch? 1.7.5.x
Description? When a module handle its tabs by itself, reseting it will throw an exception in some case.
Type? bug fix
Category? CO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Manage your tabs manually with a module (new parent with 2 children), then reset it. You will get the following error until you apply this PR.

exception_on_reset


This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Nov 7, 2018

👍 for me (I used this module to test /c @marionf => https://github.com/mickaelandrieu/masterclass/archive/master.zip

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Nov 7, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 7, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Nov 7, 2018

LGTM, thanks everyone for the reviews

@mickaelandrieu mickaelandrieu merged commit f1518c2 into PrestaShop:1.7.5.x Nov 7, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment