New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an rtlfix file to correctly hide the right side bar in rtl languages #11384

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
5 participants
@jolelievre
Contributor

jolelievre commented Nov 14, 2018

Questions Answers
Branch? 1.7.5.x
Description? Add an rtlfix file to correctly hide the right side bar in rtl languages because CSSJanus has a bug when two translations are declared one after each other
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11112
How to test?

This change is Reviewable

@jolelievre jolelievre added this to the 1.7.5.0 milestone Nov 14, 2018

@marionf marionf self-assigned this Nov 14, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 14, 2018

@marionf marionf removed their assignment Nov 14, 2018

@PierreRambaud PierreRambaud merged commit d6174fc into PrestaShop:1.7.5.x Nov 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Nov 14, 2018

Thanks @jolelievre

@jolelievre jolelievre deleted the jolelievre:rtl-sidebar branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment